refactor!: update menu-bar submenu to not extend context-menu #7013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
refactor/menu-bar-submenu
branch
from
78eda7e
to
f3ab3e2
Compare
vursen
reviewed
Dec 27, 2023
vursen
approved these changes
Dec 27, 2023
web-padawan
force-pushed
the
refactor/menu-bar-submenu
branch
from
f3ab3e2
to
948370e
Compare
|
|
This ticket/PR has been released with Vaadin 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated
vaadin-menu-bar-submenuclass to use mixins instead of extendingvaadin-context-menu.This removes a side-effect of defining
vaadin-context-menuwhen importingvaadin-menu-bar.Type of change